On 10/06/2017 03:50 AM, Bhaskar Upadhaya wrote: > > > -----Original Message----- > From: York Sun > Sent: Wednesday, September 06, 2017 9:51 PM > To: Bhaskar Upadhaya <bhaskar.upadh...@nxp.com>; u-boot@lists.denx.de > Subject: Re: [PATCH 1/1] armv8: ls1012a: Memory Map modification of kernel,env > > On 09/01/2017 02:54 AM, Bhaskar Upadhaya wrote: >> This patch adjusts memory map for images on LS1012A >> as per below memory map: >> Image Flash Offset >> RCW+PBI 0x00000000 >> Boot firmware (U-Boot) 0x00100000 > > You are changing "kernel_addr" below. > [Bhaskar] Hi York, kernel_addr is not changed, only kernel_start is changed, > so please tell does the comment is to change the Commit message or something > else.
Your subject and commit message both indicate changes of memory map. But variable kernel_start is not about memory map. You also have more changes in ls1012afrdm.h. Are they mostly white space change? If so, please separate whitespace change in another patch. York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot