On 16/12/09 10:24, Sudhakar Rajashekhara wrote: > Provides initial support for TI OMAP-L138/DA850 SoC devices on > a Logic PD EVM board. > > Provides: > Initial boot and configuration. > Support for i2c. > UART support (console). > > Signed-off-by: Sudhakar Rajashekhara <sudhakar....@ti.com> > --- > board/davinci/da8xxevm/Makefile | 1 + > board/davinci/da8xxevm/da850evm.c | 124 > +++++++++++++++++++++++++++++++ > include/asm-arm/arch-davinci/hardware.h | 1 + > 3 files changed, 126 insertions(+), 0 deletions(-) > create mode 100644 board/davinci/da8xxevm/da850evm.c >
[...] > diff --git a/board/davinci/da8xxevm/da850evm.c > b/board/davinci/da8xxevm/da850evm.c > new file mode 100644 > index 0000000..92548e2 > --- /dev/null > +++ b/board/davinci/da8xxevm/da850evm.c > @@ -0,0 +1,124 @@ > +/* > + * (C) Copyright 2009, Texas Instruments, Inc. http://www.ti.com/ > + * > + * Based on da830evm.c At this point, this seem to be a copy of da830evm.c (well except the first few lines above). Copied code is not good. I have changes still in the pipe line for da830evm.c for adding support for NAND and Ethernet and there is a USB patch out there IIRC. Since the da850 is so similar, I suspect we can at least factor out the common parts so that we don't have to edit two files to add NAND support for example. I think it is the case that the only difference is DDR instead of SDRAM and the UBL will handle that for us. Is that true for the device *and* the EVM? If so, then possibly da830evm.c could be renamed to da8xxevm.c and the code kept completely common - at the risk of adding a few ifdefs later. Nick. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
