On 09/23/2017 07:53 PM, Tom Rini wrote: > On Sat, Sep 23, 2017 at 07:43:09PM +0200, Marek Vasut wrote: >> On 09/23/2017 07:37 PM, Tom Rini wrote: >>> On Sat, Sep 23, 2017 at 07:33:44PM +0200, Marek Vasut wrote: >>>> On 09/23/2017 07:05 PM, Tom Rini wrote: >>>>> On Sat, Sep 23, 2017 at 08:56:08AM -0400, Tom Rini wrote: >>>>>> On Sat, Sep 23, 2017 at 12:39:44PM +0200, Marek Vasut wrote: >>>>>>> On 09/22/2017 04:20 PM, Tom Rini wrote: >>>>>>>> On Fri, Sep 15, 2017 at 01:15:25PM -0400, Tom Rini wrote: >>>>>>>> >>>>>>>>> With support for overlays and calling the -@ flag to dtc we need to >>>>>>>>> have >>>>>>>>> at least 1.4.3 available now. >>>>>>>>> >>>>>>>>> Cc: Simon Glass <s...@chromium.org> >>>>>>>>> Reported-by: Stephen Warren <swar...@wwwdotorg.org> >>>>>>>>> Signed-off-by: Tom Rini <tr...@konsulko.com> >>>>>>>> >>>>>>>> Applied to u-boot/master, thanks! >>>>>>> >>>>>>> Debian still only has 1.4.2 even in unstable, so u-boot/master no longer >>>>>>> builds on any debian system. >>>>>> >>>>>> Then perhaps we need to mirror the kernel and provide / build dtc, but >>>>>> allow for people to override it. >>>>> >>>>> This isn't too hard and I'm pushing that through Jenkins now to confirm >>>>> I've got all the logic correct. I think this will be the least error >>>>> prone method long term. >>>> >>>> NAK, this is the same thing which chromium does and what Debian is >>>> trying to stop -- vendoring. We will end up with patched custom DTC out >>>> of sync with upstream. >>> >>> Shrug, it's what Linux does, and what QEMU does, and probably what other >>> projects do as well since apparently even Debian/Unstable is 2 releases >>> and nearly a year behind (or, 9 months if you don't want to exaggerate). >> >> And it will likely stay that way for debian stable. I am really >> disappointed in the "Shrug" reaction to such massive breakage. > > Nope and nor will it catch old-stable breaking in January when gcc-6.x > or newer is required. >
Above you have been discussing code duplication. This is not the right way to work with git. The git way is to add https://git.kernel.org/pub/scm/utils/dtc/dtc.git as git submodule (https://git-scm.com/docs/git-submodule). In our make file we can then use git submodule init, git submodule update, git verify-tag before we build a dtc with the appropriate version. This way we can build dtc from sources but stay in sync with the upstream. Regards Heinrich _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
