Greg Ren wrote: > Jerry Van Baren wrote: > >> When you respin your patch, please put the "ping with an odd length >> causes an incorrect checksum bug" in the commit message for future >> reference. > >> Thanks, >> gvb > > The change was to the general checksum calculation. So there is enough > reason to believe that any odd-length packet may suffer the same fate. > Ping is just an easier way to test and verify the fix. > > regards > Greg Ren
Understood. My point was your original commit message did not identify *how* to exercise the bug (i.e. ping with an odd length packet). That is very valuable information because it helps us remember what was broken and how to test both the brokenness and the fix. Thanks, gvb _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
