Hi Philipp,
On 07/27/2017 09:09 PM, Dr. Philipp Tomsich wrote:
On 27 Jul 2017, at 15:04, Kever Yang <kever.y...@rock-chips.com> wrote:
Philipp,
On 07/27/2017 08:16 PM, Dr. Philipp Tomsich wrote:
Kever,
On 27 Jul 2017, at 13:47, Kever Yang <kever.y...@rock-chips.com> wrote:
The emmc number is 0, correct it for fastboot parameter.
I provided some code in rk3399-board-spl.c (commit d02d11f8; see
spl_node_to_boot_device(…) and how 'desc->devnum’ is accessed there)
to map from a of_node back to a device-number.
Could you do something similar for the fastboot case, so we can have a DTS
property (e.g. under /config or /chosen) to map back to the devnum on a
per-board basis?
I'm not sure if there two are similar the same case, for boot device, we
want to support more then one devices in an order, but for fastboot,
we usually do not support device other than eMMC.
Sorry for being a bit unspecific (but had hoped that the reference to the
function
resolving a single of_node back to a devnum would have clarified what I intended
to say)…
I didn’t mean for you to use an ordered list, but rather a single referenced
node.
E.g.
u-boot,fastboot-flash-device = <&sdmmc>;
I try to under stand what you want to do here, but again, I think this
is different
with the boot order. The boot order have much choice, different
sequence, so it's
reasonable for what you have done. But the FLASH_MMC_DEV is only one number,
not a list, not a node, just like CONFIG_SYS_MMC_ENV_DEV, it's quite
easy to do it,
we do not need to write it in dts and decode the dts, what we need is
give the correct
number to fastboot driver, and that's all.
Thanks,
- Kever
Thanks,
- Kever
Signed-off-by: Kever Yang <kever.y...@rock-chips.com>
---
include/configs/rk3288_common.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h
index 488d679..4489323 100644
--- a/include/configs/rk3288_common.h
+++ b/include/configs/rk3288_common.h
@@ -66,7 +66,7 @@
#define CONFIG_CMD_FASTBOOT
#define CONFIG_USB_FUNCTION_FASTBOOT
#define CONFIG_FASTBOOT_FLASH
-#define CONFIG_FASTBOOT_FLASH_MMC_DEV 1 /* eMMC */
+#define CONFIG_FASTBOOT_FLASH_MMC_DEV 0 /* eMMC */
#define CONFIG_FASTBOOT_BUF_ADDR CONFIG_SYS_LOAD_ADDR
#define CONFIG_FASTBOOT_BUF_SIZE 0x08000000
--
1.9.1
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
