On Thu, Aug 10, 2017 at 2:32 PM, <yuiko.osh...@microchip.com> wrote: >>-----Original Message----- >>From: Joe Hershberger [mailto:joe.hershber...@ni.com] >>Sent: Thursday, August 10, 2017 2:45 PM >>To: Yuiko Oshino - C18177 >>Cc: Marek Vasut; u-boot; Joe Hershberger >>Subject: Re: [U-Boot] [PATCH v3 1/2] usb: net: Add support for Microchip >>LAN75xx and LAN78xx >> >>On Thu, Aug 10, 2017 at 1:13 PM, <yuiko.osh...@microchip.com> wrote: >>> Hi Marek, >>> >>>>-----Original Message----- >>>>From: Marek Vasut [mailto:ma...@denx.de] >>>>Sent: Wednesday, August 9, 2017 1:12 PM >>>>To: Yuiko Oshino - C18177; u-boot@lists.denx.de >>>>Cc: Joe Hershberger >>>>Subject: Re: [PATCH v3 1/2] usb: net: Add support for Microchip >>>>LAN75xx and LAN78xx >>>> >>>>On 08/09/2017 06:25 PM, yuiko.osh...@microchip.com wrote: >>>>> From: Yuiko Oshino <yuiko.osh...@microchip.com> >>>>> >>>>> Series-Changes: 3 >>>> >>>>FYI, this will end in the commit message when applied, remove it or >>>>move it below the --- . Also commit message is missing. >>> >>> I did my best to follow the patman instructions and I added "commit-notes:" >>> tag, >>but I guess it wasn't good enough. >> >>You need to not use commit notes here. That's for things that you want to be a >>note in the email, but not end up in the commit log. > > Understood. So what is the "commit message" that Marek meant that I missed?
This: Add support for Microchip LAN7500, LAN7800 and LAN7850, USB to 10/100/1000 Ethernet Controllers. > >> >>> Should I always manually edit the patch before sending email in the patman? >> >>No, you shouldn't have to. The reason this failed to be removed is that you >>capitalized the 'C' in changes, and it didn't see it. > > I see... > >> >>Also, these tags are parsed and included as notes. You don't want to put >>these in >>a commit notes tag. That's only needed for other random commit notes. >> > What are "threse"? The tags I was referring to the Series-*: tags. It seemed like you were putting those tags into the Commit-notes: since that's there they should ultimately end up, but I'm saying that it happens for you. There should not be any nested tags. >>> Also, when I am ready to update this patch again, should I do a series or >>> just this >>patch? >> >>Do the series. Also, you should have the dependency patch first, and the >>dependent patch second (swap them around). >> >>> How can I update the [PATCH v] number? If just his patch, then will it be >>> [PATCH >>v4]? >> >>Go ahead and use v4. So use: >> >>Series-version: 4 >> > > Got it. > >>>> >>>>> - All #ifdef CONFIG_DM_ETH and #endif are removed. >>>>> - The lan7x_eth_recv() is modifed to correctly support the Driver Model >>>>> and returns packet_en. >>>>> - Add mii_resolve_flowctrl_fdx() patch in the series. >>>>> >>>>> Series-Changes: 2 >>>>> - The wait_for_bit functions copy the real one. >>>>> - Uses phylib >>>>> - Unnecessary variables are removed >>>>> - All return values are checked >>>>> - Uses mii_resolve_flowctrl_fdx() from linux/mii.h >>>>> >>>>> Signed-off-by: Yuiko Oshino <yuiko.osh...@microchip.com> >>>>> --- >>>>> Add support for Microchip LAN7500, LAN7800 and LAN7850, USB to >>>>> 10/100/1000 Ethernet Controllers. >> >>The fact that this is in the notes means that you put it under >>"Commit-notes:" ... >>"END" >> > Yes, I did. Is the Commit-notes: == Commit message? That's not correct. Commit-notes: is for the random other notes that you want not to be in git. Just like not using patman, the standard un-tagged text is the Commit message. > Do I still need this tag? No, unless you have something to say in the notes beyond the change comments. > Following tags are all I need? > Series-to: u-boot > Series-version: 4 > Series-changes: 4 > Series-changes: 3 > Series-changes: 2 > Series-changes: 1 Presumably there is no change for the initial version. > Signed-off-by: Yuiko Oshino <yuiko.osh...@microchip.com> > > Should I add Acked-by:? Yes, you should add any Acked-by that you got on a previous version to the commit so it is already included in all following versions. >>>>> >>>>> >>>>> drivers/usb/Kconfig | 2 + >>>>> drivers/usb/eth/Kconfig | 17 ++ >>>>> drivers/usb/eth/Makefile | 2 + >>>>> drivers/usb/eth/lan75xx.c | 318 +++++++++++++++++++++++++++++ >>>>> drivers/usb/eth/lan78xx.c | 477 >>>>++++++++++++++++++++++++++++++++++++++++++++ >>>>> drivers/usb/eth/lan7x.c | 495 >>>>++++++++++++++++++++++++++++++++++++++++++++++ >>>>> drivers/usb/eth/lan7x.h | 230 +++++++++++++++++++++ >>>>> 7 files changed, 1541 insertions(+) >> >>-Joe > > Thank you, Joe. > Yuiko _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
