On Tue, Aug 8, 2017 at 6:03 PM, Heinrich Schuchardt <xypron.g...@gmx.de> wrote: > On 08/04/2017 09:31 PM, Rob Clark wrote: >> This is convenient for efi_loader which deals a lot with utf16. >> >> Signed-off-by: Rob Clark <robdcl...@gmail.com> > > Please, put this patch together with > [PATCH] vsprintf.c: add GUID printing > https://patchwork.ozlabs.org/patch/798362/ > and > [PATCH v0 06/20] common: add some utf16 handling helpers > https://patchwork.ozlabs.org/patch/797968/ > into a separate patch series. > > These three patches can be reviewed independently of the efi_loader > patches and probably will not be integrated via the efi-next tree. > >> --- >> lib/vsprintf.c | 30 ++++++++++++++++++++++++++++-- >> 1 file changed, 28 insertions(+), 2 deletions(-) >> >> diff --git a/lib/vsprintf.c b/lib/vsprintf.c >> index 874a2951f7..0c40f852ce 100644 >> --- a/lib/vsprintf.c >> +++ b/lib/vsprintf.c >> @@ -17,6 +17,7 @@ >> #include <linux/ctype.h> >> >> #include <common.h> >> +#include <charset.h> >> >> #include <div64.h> >> #define noinline __attribute__((noinline)) >> @@ -270,6 +271,26 @@ static char *string(char *buf, char *end, char *s, int >> field_width, >> return buf; >> } >> >> +static char *string16(char *buf, char *end, u16 *s, int field_width, >> + int precision, int flags) >> +{ >> + u16 *str = s ? s : L"<NULL>"; > Please, do not use the L-notation here as it requires -fshort-wchar. > As we currently cannot switch the complete project to C11 you cannot use > the u-notation either. >
actually, one thought.. unlike -fshort-wchar, we could probably switch u-boot over to c11 piecemeal, if there are a lot of places where things need to be fixed for c11. For example start by switching efi_loader and vsprintf.c ;-) (I'm not completely sure what the issues are, so this may or may not make sense.. but if c11 is causing a lot of compile errors all over the place, this might be a reasonable approach.) BR, -R _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
