On Thu, Jul 06, 2017 at 03:58:27PM +0200, Christophe LEROY wrote:
> Dear Wolfgang,
>
> Le 06/07/2017 à 13:12, Wolfgang Denk a écrit :
> >Dear Christophe,
> >
> >In message <20170706083955.0d92f69...@pc13941vm.idsi0.si.c-s.fr> you wrote:
> >>
> >>This patch adds support for the first board.
> >...
> >
> >>diff --git a/board/cssi/MCR3000/u-boot.lds b/board/cssi/MCR3000/u-boot.lds
> >>new file mode 100644
> >>index 0000000000..2234bd8d1d
> >>--- /dev/null
> >>+++ b/board/cssi/MCR3000/u-boot.lds
> >...
> >>+OUTPUT_ARCH(powerpc)
> >>+SECTIONS
> >>+{
> >>+ /* Read-only sections, merged into text segment: */
> >>+ . = + SIZEOF_HEADERS;
> >>+ .text :
> >>+ {
> >...
> >
> >Like with C code, TABs should be used for indentation.
>
> Ok
>
> >
> >
> >...
> >>diff --git a/include/configs/MCR3000.h b/include/configs/MCR3000.h
> >>new file mode 100644
> >>index 0000000000..53d4e9468a
> >>--- /dev/null
> >>+++ b/include/configs/MCR3000.h
> >...
> >>+#define CONFIG_IPADDR 192.168.0.3
> >>+#define CONFIG_SERVERIP 192.168.0.1
> >>+#define CONFIG_NETMASK 255.0.0.0
> >
> >Static network configuration in board config files is strongly
> >discouraged. Please remove.
>
> But with no IP CONFIG, the board won't boot properly.
> I propose to leave it for the time being (there is plenty in other
> board configs) and add that in my TODO list.Agreed. Figuring out what to do about these CONFIG options is somewhere on my list as it's indeed against best practices now. -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
