Le 21/06/2017 à 17:51, Heiko Schocher a écrit :
Hello Christophe,

Am 21.06.2017 um 17:22 schrieb Tom Rini:
On Wed, Jun 21, 2017 at 05:09:09PM +0200, Christophe Leroy wrote:

CS Systemes d'Information (CSSI) manufactures two boards, named MCR3000
and CMPC885 which are respectively based on MPC866 and MPC885.
This patch is the skeleton to allow soon inclusion of support for
those two boards.

Signed-off-by: Christophe Leroy <christophe.le...@c-s.fr>
---
  The source code for those two boards needs consequent cleanup
before being suitable for inclusion, however we need to stop
8xx deletion hemoragia as soon as possible.

With what I'm going to send out as a v2 of the rest of the series, I'm
OK with not including an empty directory for now and bringing back
mpc8xx, thanks again!

Hmm.. do we really want back the old files?

Yes, I don't like the idea of a big-bang. Lets clean it up step by step, as done for other targets.


Just a fast look in the patchstatistic:

  arch/powerpc/cpu/mpc8xx/spi.c          |  533 ++++++++++++

No, spi drivers are in drivers/spi nowadays

  arch/powerpc/cpu/mpc8xx/scc.c          |  472 +++++++++++
  arch/powerpc/cpu/mpc8xx/fec.c          |  933 +++++++++++++++++++++
  arch/powerpc/cpu/mpc8xx/fec.h          |   12 +

-> driver/net

  arch/powerpc/cpu/mpc8xx/serial.c       |  676 ++++++++++++++++

-> drivers/serial

Only fast look into:
arch/powerpc/cpu/mpc8xx/spi.c

         cp->cp_pbpar |=  0x0000000E;    /* set  bits    */

No use of ioaccesors, no defines for magic values ...:-(

DM support? Cleanup for Kconfig support?

One reason of the remove was, that the mpc8xx files wasn;t in a good
shape, and nobody volunteered for cleaning it up ...

I do volunteer for cleaning it up .... but definitly not for re-starting from scratch.


Are there plans to clean this up ?

I will do it, but I'd like to start from an existing situation, not start from scratch.


If no: NACK from me, sorry.

Why not posting a patchset, which introduce mpc8xx support only?

We have a basis that is maybe old, but works. For me it is a better starting point.

Christophe
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to