> -----Original Message----- > From: york sun > Sent: Tuesday, May 23, 2017 7:11 PM > To: Bogdan Purcareata <bogdan.purcare...@nxp.com>; Prabhakar Kushwaha > <prabhakar.kushw...@nxp.com>; u-boot@lists.denx.de > Cc: Heinz Wrobel <heinz.wro...@nxp.com> > Subject: Re: [PATCH v2 1/2] drivers: net: fsl-mc: Link MC boot to > PHY_RESET_R > > On 05/19/2017 07:00 AM, Bogdan Purcareata wrote: > > DPAA2 platforms boot the Management Complex based on the u-boot env > > variable "mcinitcmd". Instead of doing this step on each platform > > individually, define a single mc_env_boot function in the MC driver, > > since it's semantically tied to it. > > > > Call the function in a per-board reset_phy hook, as it gets called at a > > later moment, when all board PHY devices have been initialized. > > > > Signed-off-by: Bogdan Purcareata <bogdan.purcare...@nxp.com> > > Signed-off-by: Heinz Wrobel <heinz.wro...@nxp.com> > > --- > > v1 -> v2: > > - keep the reset_phy implementation on each board; some boards might > > want to do something else besides booting the MC. > > > > board/freescale/ls2080aqds/eth.c | 13 ++++++------- > > board/freescale/ls2080ardb/eth_ls2080rdb.c | 14 ++++++++------ > > drivers/net/fsl-mc/mc.c | 16 ++++++++++++++++ > > include/configs/ls2080a_common.h | 5 +++++ > > include/fsl-mc/fsl_mc.h | 1 + > > 5 files changed, 36 insertions(+), 13 deletions(-) > > > > <snip> > > > diff --git a/include/configs/ls2080a_common.h > b/include/configs/ls2080a_common.h > > index 427f623..266ef02 100644 > > --- a/include/configs/ls2080a_common.h > > +++ b/include/configs/ls2080a_common.h > > @@ -149,6 +149,11 @@ unsigned long long get_qixis_addr(void); > > #define CONFIG_SYS_LS_MC_AIOP_IMG_MAX_LENGTH 0x200000 > > #define CONFIG_SYS_LS_MC_DRAM_AIOP_IMG_OFFSET 0x07000000 > > > > +/* Define phy_reset function to boot the MC based on mcinitcmd. > > + * This happens late enough to properly fixup u-boot env MAC addresses. > > + */ > > +#define CONFIG_RESET_PHY_R > > + > > You enabled this macro but didn't not add dummy call for ls2080a_simu > and ls2080a_emu targets, causing compiling error.
Will include in v3, thanks! Bogdan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
