Hi Stefano, Jagan, I have been trying to add the dts support for this board but I could not make Ethernet, I2C and PMIC support work using dts.
I am still trying to add this support but I don't know how much time it can take. I'm new to U-Boot. Can you please consider applying the original patch? Thanks in advance! Regards, Vanessa Maegima ________________________________ From: Vanessa Ayumi Maegima <van.ay...@gmail.com> Sent: Tuesday, May 9, 2017 10:45:20 AM To: Stefano Babic Cc: Vanessa Maegima; Jagan Teki; Fabio Estevam; u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] pico-imx7d: Add initial support Hi Stefano, Jagan, On Tue, May 9, 2017 at 5:23 AM, Stefano Babic <sba...@denx.de<mailto:sba...@denx.de>> wrote: Hi Jagan, Vanessa, On 08/05/2017 21:49, Jagan Teki wrote: > Though the code look good and similar approach of existing boards, I'm > little concern of continue the same legacy and w/o trying new feature > like fdt. > > We've few i.MX boards which uses fdt support please refer the same. > I'm commenting below what all the code can removed ans use it with > dts. It is worth a couple og thoughts. Even if the path to a u-boot configured via fdt is clear, this should be done if this does not block other feature that are maybe important for the project - and this is known only by the board maintainer. I do not talk about this particular board - the issue is general and I remain general. For example, it looks to me that having a single binary for multiple variants of the board cannot be easy reached. There is a DTS for each variant and this means a binary for each of them. This is ok for some projects, it is not ok for some other ones. And I cannot constrain people to go into a direction when they lose features. I did quite the same approach with SPL / u-boot.imx. I understand that some projects want to stick with a single binary instead of two, it remains a decision of board maintainer. No block on my site. Last concern is related to size in SPL. imx6.Solo has just 64Kb RAM, but less are available because a part is reserved to the BootRom (or HAB, or whatever). And putting a lot of stuff inside SPL is not possible, then. After saying all this, back to the specific case. Vanessa, you are not using SPL and you have put the RAM configuration into the DCD table. Then it is everything fix and you cannot have more variants. That means your board has not the drawbacks I mentioned above. It could be a good candidate to use dts. What do you think ? Best regards, Stefano Babic I will add the dts support and send a v2. Thanks for the review! Best Regards, Vanessa Maegima​ _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
