On 11/05/2017 11:34, Peng Fan wrote:
> Each time set_state is called, a new piece memory will
> be allocated for pin_data, but not freed, this will
> incur memory leak.
>
> When error, the devm API could not free memory automatically.
> So need call devm_kfree when error.
>
> Issue reported by Coverity
>
> Signed-off-by: Peng Fan <peng....@nxp.com>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Stefan Agner <stefan.ag...@toradex.com>
> Cc: Stefano Babic <sba...@denx.de>
> ---
> drivers/pinctrl/nxp/pinctrl-imx.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/pinctrl/nxp/pinctrl-imx.c
> b/drivers/pinctrl/nxp/pinctrl-imx.c
> index f0321c4..ebc14a3 100644
> --- a/drivers/pinctrl/nxp/pinctrl-imx.c
> +++ b/drivers/pinctrl/nxp/pinctrl-imx.c
> @@ -53,6 +53,7 @@ static int imx_pinctrl_set_state(struct udevice *dev,
> struct udevice *config)
> if (fdtdec_get_int_array(gd->fdt_blob, node, "fsl,pins",
> pin_data, size >> 2)) {
> dev_err(dev, "Error reading pin data.\n");
> + devm_kfree(dev, pin_data);
> return -EINVAL;
> }
>
> @@ -78,6 +79,7 @@ static int imx_pinctrl_set_state(struct udevice *dev,
> struct udevice *config)
>
> if ((mux_reg == -1) || (conf_reg == -1)) {
> dev_err(dev, "Error mux_reg or conf_reg\n");
> + devm_kfree(dev, pin_data);
> return -EINVAL;
> }
>
> @@ -166,6 +168,8 @@ static int imx_pinctrl_set_state(struct udevice *dev,
> struct udevice *config)
> }
> }
>
> + devm_kfree(dev, pin_data);
> +
> return 0;
> }
>
>
Applied to u-boot-imx, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de
=====================================================================
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot
