On Sat, Mar 4, 2017 at 7:05 PM, Tom Rini <tr...@konsulko.com> wrote:
> On Sat, Mar 04, 2017 at 06:36:28PM +0000, Peter Robinson wrote:
>> The Cubox-i and Hummingboard series of devices have an option of
>> SATA on board, and depending on how the fuses are blown even the
>> option to boot SPL from SATA. So enable support for it so it can
>> be used to boot the OS from if people desire.
>>
>> Signed-off-by: Peter Robinson <pbrobin...@gmail.com>
>> ---
>>  board/solidrun/mx6cuboxi/mx6cuboxi.c |  7 +++++++
>>  include/configs/mx6cuboxi.h          | 12 ++++++++++++
> [snip]
>> +/* SATA Configuration */
>> +#define CONFIG_CMD_SATA
>> +#ifdef CONFIG_CMD_SATA
>
> Please move CMD_SATA to cmd/Kconfig.  You don't have to migrate everyone
> over.

New patch series, well one for the CMD_SATA stuff, coming that I
believe addresses that.

>> +#define CONFIG_DWC_AHSATA
>> +#define CONFIG_SYS_SATA_MAX_DEVICE      1
>> +#define CONFIG_DWC_AHSATA_PORT_ID       0
>> +#define CONFIG_DWC_AHSATA_BASE_ADDR     SATA_ARB_BASE_ADDR
>> +#define CONFIG_LBA48
>> +#define CONFIG_LIBATA
>
> Bonus points if you move some these over to the existing sata section on
> drivers/block/Kconfig :)

I'm looking at a few of those as well but I'll send that separately.

Patches inbound shortly, sorry for the delays.

Peter
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to