Hi Simon,
2017-05-11 6:43 GMT+09:00 Tom Rini <tr...@konsulko.com>: > On Mon, May 01, 2017 at 09:18:44AM -0600, Simon Glass wrote: > >> This header includes things that are needed to make driver build. Adjust >> existing users to include that always, even if other dm/ includes are >> present >> >> Signed-off-by: Simon Glass <s...@chromium.org> > > Reviewed-by: Tom Rini <tr...@konsulko.com> > I'd say this is a bad idea. I believe .c files should include headers that are really necessary. Mostly, drivers need only dm/device.h, but this commit requires additional parse of dm/uclass.h and dm/platdata.h. Rather, it is better to deprecate dm.h. Its concept is DM common header that you force drivers to include where some in them may not be necessary. It is a similar idea to include/common.h, which is one of the biggest design mistakes in U-Boot. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
