On 05/03/2017 11:44 PM, Heinrich Schuchardt wrote:
The logical expression to check the dtb is incorrect in
load_devicetree.

The problem was indicated by cppcheck.

Signed-off-by: Heinrich Schuchardt <xypron.g...@gmx.de>
---
I do not have a board for testing.
Please, review carefully.
---
  board/BuR/common/common.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/board/BuR/common/common.c b/board/BuR/common/common.c
index 876150402c..c0316b9ebd 100644
--- a/board/BuR/common/common.c
+++ b/board/BuR/common/common.c
@@ -265,7 +265,7 @@ static int load_devicetree(void)
        char *dtbname = getenv("dtb");
        char *dtbdev = getenv("dtbdev");
        char *dtppart = getenv("dtbpart");
-       if (!dtbdev || !dtbdev || !dtbname) {
+       if (!dtbdev || !dtbpart || !dtbname) {
                printf("%s: <dtbdev>/<dtbpart>/<dtb> missing.\n", __func__);
                return -1;
        }
Reviewed-by: Hannes Schmelzer <oe5...@oevsv.at>
Acked-by: Hannes Schmelzer <oe5...@oevsv.at>

Thanks!

_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
https://lists.denx.de/listinfo/u-boot

Reply via email to