Hi Eddie, On 2 May 2017 at 04:37, Eddie Cai <eddie.cai.li...@gmail.com> wrote: > Hi Simon > 2017-03-20 10:30 GMT+08:00 Simon Glass <s...@chromium.org>: >> Hi Eddie. >> >> On 15 March 2017 at 01:56, Eddie Cai <eddie.cai.li...@gmail.com> wrote: >>> this patch enable rockusb support on rk3288 based device. >>> >>> Signed-off-by: Eddie Cai <eddie.cai.li...@gmail.com> >>> --- >>> include/configs/rk3288_common.h | 4 ++++ >>> 1 file changed, 4 insertions(+) >> >> I think this should be done in Kconfig. > since rockusb used so widely on rockchip soc based devices. every > rockchip soc based > device should support it. So I would like to put it in rk3288_common.h > or even rockchip-common.h. > what do you think?
We are moving to removing the board config headers so cannot add new non-Kconfig CONFIG options. You can add it to arch/arm/Kconfig - e.g. with 'imply CONFIG_....' under 'config ARCH_ROCKCHIP'. Please help to remove any options you can from the headers. >> >>> >>> diff --git a/include/configs/rk3288_common.h >>> b/include/configs/rk3288_common.h >>> index b5606d4..b19a34d 100644 >>> --- a/include/configs/rk3288_common.h >>> +++ b/include/configs/rk3288_common.h >>> @@ -74,6 +74,10 @@ >>> #define CONFIG_FASTBOOT_BUF_ADDR CONFIG_SYS_LOAD_ADDR >>> #define CONFIG_FASTBOOT_BUF_SIZE 0x08000000 >>> >>> +/* rockusb */ >>> +#define CONFIG_CMD_ROCKUSB >>> +#define CONFIG_USB_FUNCTION_ROCKUSB >>> + >>> /* usb mass storage */ >>> #define CONFIG_USB_FUNCTION_MASS_STORAGE >>> #define CONFIG_CMD_USB_MASS_STORAGE >>> -- >>> 2.7.4 Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
