Hi Tom, On 25 April 2017 at 11:12, Tom Rini <tr...@konsulko.com> wrote: > > On Sat, Apr 22, 2017 at 05:53:36PM -0600, Simon Glass wrote: > > +Tom > > > > On 19 April 2017 at 07:24, Philipp Tomsich > > <philipp.toms...@theobroma-systems.com> wrote: > > > > > > This change encodes the CC list to UTF-8 to avoid failures on > > > maintainer-addresses that include non-ASCII characters (observed on > > > Debian 7.11 with Python 2.7.3). > > > > > > Without this, I get the following failure: > > > Traceback (most recent call last): > > > File "tools/patman/patman", line 159, in <module> > > > options.add_maintainers) > > > File "[snip]/u-boot/tools/patman/series.py", line 234, in MakeCcFile > > > print(commit.patch, ', '.join(set(list)), file=fd) > > > UnicodeEncodeError: 'ascii' codec can't encode character u'\xfc' in > > > position 81: ordinal not in range(128) > > > from Heiko's email address: > > > [..., u'"Heiko St\xfcbner" <he...@sntech.de>', ...] > > > > > > While with this change added this encodes to: > > > "=?UTF-8?q?Heiko=20St=C3=BCbner?= <he...@sntech.de>" > > > > > > Signed-off-by: Philipp Tomsich <philipp.toms...@theobroma-systems.com> > > > --- > > > > > > tools/patman/series.py | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > Reviewed-by: Simon Glass <s...@chromium.org> > > Please put this in a PR for me, along with any other critical fixes to > the various python tools we have, thanks! > > And also, do we need to perhaps whack something at a higher level, and > more consistently, about unicode? This is, I gather, doing UTF-8 right. > In buildman we have a few patches to just translate to latin-1 instead. > We should do the same thing I think, and perhaps there's a higher level > up in the code where we need to do it too? I don't know..
Actually I don't think we are quite there yet. This really needs a test with all the different places strings can come from, to make sure patman does the right thing. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
