-----Original Message----- From: York Sun [mailto:york....@nxp.com] Sent: Tuesday, April 18, 2017 10:07 PM To: Amrita Kumari <amrita.kum...@nxp.com>; u-boot@lists.denx.de Cc: Bhaskar U <bhaskar.upadh...@nxp.com> Subject: Re: [U-Boot] [PATCH] ls1012a: Some Bootargs and env variables added for booting kernel
On 04/18/2017 08:43 AM, Amrita Kumari wrote: > From: Amrita kumari <amrita.kum...@nxp.com> > > Signed-off-by: Amrita kumari <amrita.kum...@nxp.com> > --- > include/configs/ls1012a_common.h | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/include/configs/ls1012a_common.h > b/include/configs/ls1012a_common.h > index e556c92..0a80802 100644 > --- a/include/configs/ls1012a_common.h > +++ b/include/configs/ls1012a_common.h > @@ -95,17 +95,23 @@ > > /* Initial environment variables */ > #define CONFIG_EXTRA_ENV_SETTINGS \ > + "initrd_high=0xffffffff\0" \ > "verify=no\0" \ > + "hwconfig=fsl_ddr:bank_intlv=auto\0" \ Why do you need hwconifg for DDR? LS1012A doesn't even use the same DDR controller as other qoriq/layerscape SoCs. > "loadaddr=0x80100000\0" \ > "kernel_addr=0x100000\0" \ > + "ramdisk_addr=0x800000\0" \ Why do you even need this variable? > + "ramdisk_size=0x2000000\0" \ This is not used anywhere, except you added it in bootargs below. You can leave it in bootargs if you need it. > "fdt_high=0xffffffffffffffff\0" \ > "initrd_high=0xffffffffffffffff\0" \ Don't you see you already have initrd_high? Why do you want to change it back to 32-bit? > "kernel_start=0xa00000\0" \ > "kernel_load=0xa0000000\0" \ > "kernel_size=0x2800000\0" \ > + "console=ttyAMA0,38400n8\0" Why on earth do you need this? > > #define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/ram0 " \ > - "earlycon=uart8250,mmio,0x21c0500 quiet > lpj=250000" > + "earlycon=uart8250,mmio,0x21c0500 quiet " \ > + "lpj=250000 ramdisk_size=0x2000000" > #define CONFIG_BOOTCOMMAND "sf probe 0:0; sf read $kernel_load "\ > "$kernel_start $kernel_size && "\ > "bootm $kernel_load" > I don't know what you were trying to do. This patch is non-sense. [Bhaskar] Hi York, The intension of the patch is to add ramdisk_size=0x2000000 in bootargs, so is it OK to just add " ramdisk_size=0x2000000" in the bootargs and remove whatever else have been added in this patch ? York _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
