Hi Tom, On 17 April 2017 at 07:33, Tom Rini <tr...@konsulko.com> wrote: > > On Mon, Apr 17, 2017 at 10:13:06PM +0900, Masahiro Yamada wrote: > > Hi Tom, > > > > > > 2017-04-17 22:05 GMT+09:00 Tom Rini <tr...@konsulko.com>: > > > On Sun, Apr 16, 2017 at 08:22:17PM -0600, Simon Glass wrote: > > > > > >> These should follow the UBoot standard. Update them. > > >> > > >> Signed-off-by: Simon Glass <s...@chromium.org> > > >> --- > > >> > > >> include/fdt.h | 46 +--------------------------------------------- > > >> include/libfdt.h | 46 +--------------------------------------------- > > >> 2 files changed, 2 insertions(+), 90 deletions(-) > > > > > > We're syncing these as-is, right? If so, just like DTB files, we don't > > > need to whack in an SPDX tag as that just complicates future re-syncs. > > > > Do we have consistent policy for this? > > > > For example, > > > > git show 5b8031ccb4e -- scripts/kconfig/ > > > > ... complicates Kconfig re-syncs? > > We ought to be consistent here, and if you happen to stomp on that next > time you re-sync I really can't complain. We certainly don't do it in > dtb files as that's just annoyed upstream when people have tried to push > the changes back up. In cases where we are able to 100% drop-in > upstream files, it's best to not do the conversion. In other cases, say > MTD and 78e9e71c83cf, we have other changes, re-sync requires attention > and we do have some U-Boot'isms, we might as well convert.
These files are not exactly the same, since we have different header includes and a few other features that are not yet upstream. I am always comparing the files anyway so it's no bother to ignore the license at the top. The rest of the libfdt files in U-Boot use SPDX. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
