Hi Nicholas, On 16/02/2017 19:27, Peter Robinson wrote: > On Thu, Feb 16, 2017 at 6:20 PM, Nicolas Chauvet <kwiz...@gmail.com> wrote: >> Having sata first will makes preference to sata boot if >> both sata0 and mmc0 have a boot partition >> >> This change was not tested against wanboard solo/dual, >> but it does operate correctly when there is no sata disk >> connected on quad. >> (it falls back to mmc0 boot) >> >> Tested with current u-boot 2017.03-rc2 >> with Fedora 25 workstation armhfp > > Have you tested with a non quad device that doesn't have sata? It > doesn't appear to be special cased, just blanket added. >
Just FYI: I decided to not merge it because I have not myself non quad Wandboard and this must be tested before merging. I let the patch for a long while, but I have not seen that someone else had the possibility to test it. Best regards, Stefano Babic >> Signed-off-by: Nicolas Chauvet <kwiz...@gmail.com> >> --- >> include/configs/wandboard.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h >> index 7e9757a..3101d1b 100644 >> --- a/include/configs/wandboard.h >> +++ b/include/configs/wandboard.h >> @@ -128,6 +128,7 @@ >> BOOTENV >> >> #define BOOT_TARGET_DEVICES(func) \ >> + func(SATA, sata, 0) \ >> func(MMC, mmc, 0) \ >> func(MMC, mmc, 1) \ >> func(USB, usb, 0) \ >> -- >> 2.7.4 >> >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
