On Oct 27, 2009, at 9:30 AM, Peter Tyser wrote:
> Hi Vivek,
> Thanks for this change, we'll migrate our XES boards to use it in the
> near future.
>
> On Tue, 2009-10-27 at 12:18 +0530, Vivek Mahajan wrote:
>> Originally written by Jason Jin and Mingkai Hu for mpc8536.
>>
>> When QorIQ based board is configured as a PCIe agent,
>> then unlock the config and init a 4K inbound memory
>> window; so that a PCIe host can request it.
>
> I'd replace "then unlock the config" with "unlock/enable inbound PCI
> configuration cycles" and "host can request it" with "host can access
> the PCIe agents SDRAM at address 0x0"
updated the commit msg with these changes.
>> * Supported in fsl_pci_init_port() after adding pcie_ep as a param
>> * Revamped copyright in drivers/pci/fsl_pci_init.c
>> * Mods in 85xx based board specific pci init after this change
>
> I personally think these bullets points are a bit overly verbose.
Its a commit message, verbosity isn't bad. ;)
>
> <snip>
>
>> + if (pcie_ep) {
>> + pit_t *pi = &pci->pit[2];
>
> A "volatile" needs to be added above to prevent compiler warnings.
I fixed it when I committed.
>
>> + pci_setup_indirect(hose, (u32) &pci->cfg_addr,
>> + (u32) &pci->cfg_data);
>> + out_be32(&pi->pitar, 0);
>> + out_be32(&pi->piwbar, 0);
>> + out_be32(&pi->piwar, PIWAR_EN | PIWAR_LOCAL |
>> + PIWAR_READ_SNOOP | PIWAR_WRITE_SNOOP | PIWAR_IWS_4K);
>> +
>> + fsl_pci_config_unlock(hose);
>> + return 0;
>> + }
>
> Best,
> Peter
>
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
