On 31 March 2017 at 16:31, Andre Przywara <andre.przyw...@arm.com> wrote: > Currently the SPL FIT loader uses the spl_fit_select_fdt() function to > find the offset to the right DTB within the FIT image. > For this it iterates over all subnodes of the /configuration node in > the FIT tree and compares all "description" strings therein using a > board specific matching function. > If that finds a match, it uses the string in the "fdt" property of that > subnode to locate the matching subnode in the /images node, which points > to the DTB data. > Now this works very well, but is quite specific to cover this particular > use case. To open up the door for a more generic usage, let's split this > function into: > 1) a function that just returns the node offset for the matching > configuration node (spl_fit_find_config_node()) > 2) a function that returns the image data any given property in a given > configuration node points to, additionally using a given index into > a possbile list of strings (spl_fit_select_index()) > This allows us to replace the specific function above by asking for the > image the _first string of the "fdt" property_ in the matching > configuration subnode points to. > > This patch introduces no functional changes, it just refactors the code > to allow reusing it later. > > (diff is overly clever here and produces a hard-to-read patch, so I > recommend to throw a look at the result instead). > > Signed-off-by: Andre Przywara <andre.przyw...@arm.com> > Reviewed-by: Lokesh Vutla <lokeshv...@ti.com> > --- > common/spl/spl_fit.c | 88 > ++++++++++++++++++++++++++++++++++------------------ > 1 file changed, 57 insertions(+), 31 deletions(-)
Reviewed-by: Simon Glass <s...@chromium.org> _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
