Hi Andy, On 3 March 2017 at 08:18, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Fri, Mar 3, 2017 at 6:52 AM, Simon Glass <s...@chromium.org> wrote: >> Hi Andy, >> >> On 27 February 2017 at 07:11, Andy Shevchenko >> <andriy.shevche...@linux.intel.com> wrote: >>> From: Vincent Tinelli <vincent.tine...@intel.com> >>> >>> Change GPT UUID string format from UUID to GUID per specification. >>> >>> Signed-off-by: Vincent Tinelli <vincent.tine...@intel.com> >>> --- >>> cmd/gpt.c | 2 +- >>> disk/part_efi.c | 2 +- >>> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> Reviewed-by: Simon Glass <s...@chromium.org> >> >> How about also a patch to add comments to that enum in uuid.h? > > I hope it's not a condition for your tag? Otherwise we might do this > later at some point.
No, it's a suggestion. I normally use something 'but please ...' if I think something needs to be done. However it does seem confusing, as this bug suggests. Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot
