Hello Peng,

Am 22.02.2017 um 09:21 schrieb Peng Fan:
Add lpi2c driver for i.MX7ULP.
Need to enable the two options to use this driver:
CONFIG_DM_I2C=y
CONFIG_SYS_LPI2C_IMX=y

Signed-off-by: Peng Fan <peng....@nxp.com>
Cc: Stefano Babic <sba...@denx.de>
Cc: Heiko Schocher <h...@denx.de>
---

V3:
  none
V2:
  none

  arch/arm/include/asm/arch-mx7ulp/imx_lpi2c.h | 520 +++++++++++++++++++++++++++
  drivers/i2c/Kconfig                          |   6 +
  drivers/i2c/Makefile                         |   1 +
  drivers/i2c/imx_lpi2c.c                      | 462 ++++++++++++++++++++++++
  4 files changed, 989 insertions(+)
  create mode 100644 arch/arm/include/asm/arch-mx7ulp/imx_lpi2c.h
  create mode 100644 drivers/i2c/imx_lpi2c.c


just a nitpick ...

[...]
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index 39f62da..0bee0c4 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -109,6 +109,12 @@ config SYS_I2C_INTEL
          the I2C API meaning that any I2C operations will immediately fail
          for now.

+config SYS_LPI2C_IMX
+       bool "NXP i.MX LPI2C driver"
+       depends on ARCH_MX7ULP
+       help
+         Add support for the NXP i.MX LPI2C driver.
+
  config SYS_I2C_MXC
        bool "NXP i.MX I2C driver"
        depends on MX6
diff --git a/drivers/i2c/Makefile b/drivers/i2c/Makefile
index 7c86198..2cbe3bc 100644
--- a/drivers/i2c/Makefile
+++ b/drivers/i2c/Makefile
@@ -24,6 +24,7 @@ obj-$(CONFIG_SYS_I2C_FSL) += fsl_i2c.o
  obj-$(CONFIG_SYS_I2C_FTI2C010) += fti2c010.o
  obj-$(CONFIG_SYS_I2C_IHS) += ihs_i2c.o
  obj-$(CONFIG_SYS_I2C_INTEL) += intel_i2c.o
+obj-$(CONFIG_SYS_LPI2C_IMX) += imx_lpi2c.o

All I2C config symbls have an "I2C" ... and you name the driver
imx_lpi2c, but the config symbol lpi2c_imx ... can you please
rename it to CONFIG_SYS_I2C_IMX_LPI2C and sort the list alphabetical?
(heh... with the rename it is on the correct place ;-)

Thanks!

Beside of this, you can add my:

Acked-by: Heiko Schocher <h...@denx.de>

bye,
Heiko
--
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to