On Fri, Feb 17, 2017 at 04:17:10PM -0500, Jon Mason wrote: > Add support for the Broadcom Northstar2 SoC and SVK (bcm958712k). The > BCM5871X is a series of quad-core 64-bit 2GHz ARMv8 Cortex-A57 > processors targeting a broad range of networking applications. > > Signed-off-by: Jon Mason <jon.ma...@broadcom.com> > --- > arch/arm/Kconfig | 9 ++++++ > board/broadcom/bcm958712k/MAINTAINERS | 6 ++++ > board/broadcom/bcmns2/Kconfig | 15 +++++++++ > board/broadcom/bcmns2/Makefile | 7 +++++ > board/broadcom/bcmns2/northstar2.c | 57 > +++++++++++++++++++++++++++++++++++ > configs/bcm958712k_defconfig | 9 ++++++ > include/configs/bcm_northstar2.h | 55 +++++++++++++++++++++++++++++++++ > 7 files changed, 158 insertions(+) > create mode 100644 board/broadcom/bcm958712k/MAINTAINERS > create mode 100644 board/broadcom/bcmns2/Kconfig > create mode 100644 board/broadcom/bcmns2/Makefile > create mode 100644 board/broadcom/bcmns2/northstar2.c > create mode 100644 configs/bcm958712k_defconfig > create mode 100644 include/configs/bcm_northstar2.h
I assume you have some follow up patches to add some code under
arch/arm/mach-xxxx ? Or is there just a whole bunch of stuff that's
done in ATF or similar instead? Also:
> +int dram_init(void)
> +{
> + gd->ram_size = PHYS_SDRAM_1_SIZE + PHYS_SDRAM_2_SIZE;
> + return 0;
> +}
You should be using get_ram_size() here.
[snip]
> +CONFIG_BOOTDELAY=30
Having 30 seconds here is huge. I know in your talk you were mentioning
how to interrupt boot but I'd really rather not see this exceed 10 and 5
is usually sufficient.
--
Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
