On 02/19/2017 02:10 AM, Dalon Westergreen wrote: > On Sun, 2017-02-19 at 01:37 +0100, Marek Vasut wrote: >> On 02/19/2017 12:29 AM, Dalon Westergreen wrote: >>> >>> On Sat, 2017-02-18 at 22:01 +0100, Marek Vasut wrote: >>>> >>>> On 02/18/2017 09:51 PM, Dalon Westergreen wrote: >>>>> >>>>> >>>>> This adds a common environment and support for distro boot >>>>> in the common socfpga header. >>>>> >>>>> Signed-off-by: Dalon Westergreen <dwest...@gmail.com> >>>>> --- >>>>> include/configs/socfpga_common.h | 55 >>>>> +++++++++++++++++++++++++++++++++++++--- >>>>> 1 file changed, 51 insertions(+), 4 deletions(-) >>>>> >>>>> diff --git a/include/configs/socfpga_common.h >>>>> b/include/configs/socfpga_common.h >>>>> index 582b04a..2b8be8f 100644 >>>>> --- a/include/configs/socfpga_common.h >>>>> +++ b/include/configs/socfpga_common.h >>>>> @@ -67,6 +67,9 @@ >>>>> #define CONFIG_SYS_HOSTNAME CONFIG_SYS_BOARD >>>>> #endif >>>>> >>>>> +#define CONFIG_CMD_PXE >>>>> +#define CONFIG_MENU >>>>> + >>>>> /* >>>>> * Cache >>>>> */ >>>>> @@ -245,13 +248,13 @@ unsigned int cm_get_qspi_controller_clk_hz(void); >>>>> * U-Boot environment >>>>> */ >>>>> #if !defined(CONFIG_ENV_SIZE) >>>>> -#define CONFIG_ENV_SIZE 4096 >>>>> +#define CONFIG_ENV_SIZE (8*1024) >>>>> #endif >>>>> >>>>> /* Environment for SDMMC boot */ >>>>> #if defined(CONFIG_ENV_IS_IN_MMC) && !defined(CONFIG_ENV_OFFSET) >>>>> -#define CONFIG_SYS_MMC_ENV_DEV 0 /* device 0 */ >>>>> -#define CONFIG_ENV_OFFSET 512 /* just after the >>>>> MBR >>>>> */ >>>>> +#define CONFIG_SYS_MMC_ENV_DEV 0 /* >>>>> device 0 >>>>> */ >>>>> +#define CONFIG_ENV_OFFSET (34*512)/* just after the GPT >>>>> */ >>>> >>>> Space around the asterisk . Btw this probably broke some existing >>>> configurations ... >>> >>> It may, but it is unavoidable as the env needs to be larger for >>> distro boot. >> >> I'm really not impressed ... sigh. > > I actually dont believe this will cause much of an issue. the env is placed > immediately after the partition table. I know this size fits between the > table and the typical location of the first partition without issue. >
My rant is more about breaking already running setups, but let's see if someone actually complains. -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
