On Wednesday 01 February 2017 03:12 PM, Roger Quadros wrote: > On 31/01/17 06:17, Lokesh Vutla wrote: >> >> >> On Monday 30 January 2017 08:45 PM, Roger Quadros wrote: >>> In stead of defining the board EEPROM address in the board headers >>> let's define them in the board config files and make them >>> configurable by Kconfig. >>> >>> Signed-off-by: Roger Quadros <rog...@ti.com> >>> --- >>> arch/arm/Kconfig | 10 ++++++++++ >>> configs/am57xx_evm_defconfig | 2 ++ >>> configs/am57xx_evm_nodt_defconfig | 2 ++ >>> configs/am57xx_hs_evm_defconfig | 2 ++ >>> configs/dra7xx_evm_defconfig | 2 ++ >>> configs/dra7xx_hs_evm_defconfig | 2 ++ >>> include/configs/am57xx_evm.h | 4 ---- >>> include/configs/dra7xx_evm.h | 4 ---- >>> 8 files changed, 20 insertions(+), 8 deletions(-) >>> >>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig >>> index c04adfb..19886ad 100644 >>> --- a/arch/arm/Kconfig >>> +++ b/arch/arm/Kconfig >>> @@ -1009,6 +1009,16 @@ config TARGET_THUNDERX_88XX >>> >>> endchoice >>> >>> +config EEPROM_BUS_ADDRESS >>> + int "Board EEPROM's I2C bus address" >>> + range 0 8 >>> + default 0 >>> + >>> +config EEPROM_CHIP_ADDRESS >>> + hex "Board EEPROM's I2C chip address" >>> + range 0 0xff >>> + default 0x50 >>> + >> >> IMO, these should be placed in board/ti/common/Kconfig. Also need not >> specify the value explicitly in defconfig if default value is used. > > "board/ti/common/Kconfig" is not used by keystone > Is it OK to source it in board/ti/ks2_evm/Kconfig?
yes. I don't see any problem with that :) Thanks and regards, Lokesh > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
