On Wed, Jan 25, 2017 at 06:53:13PM +1000, Fiach Antaw wrote: > This patch adds support for fat/ext4-style environments on top of > the FS api, allowing any filesystem to be used to store the u-boot > environment. This implementation also support redundancy in the > form of a secondary environment file on the same filesystem. > > Signed-off-by: Fiach Antaw <fiach.an...@uqconnect.edu.au> > > --- > > README | 22 ++++++++ > cmd/nvedit.c | 1 + > common/Makefile | 1 + > common/env_fs.c | 126 > +++++++++++++++++++++++++++++++++++++++++++ > include/environment.h | 16 ++++++ > scripts/config_whitelist.txt | 5 ++ > 6 files changed, 171 insertions(+) > create mode 100644 common/env_fs.c
Functionally, I like this idea, it's a step in the right direction. My first question is, did you test this on some real hardware that's using environment stored in a filesystem, on another media not listed here (say SATA?) ? Second, it's really, really, not a good idea to add more Kconfig options to the whitelist. Can you please take a look at starting to move the env choices to Kconfig (I would assume ENV_IS_NOWHERE would be the easiest to move) ? Then we can add this there, thanks! -- Tom
signature.asc
Description: Digital signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
