Hi Nick, Thompson, Nick (GE EntSol, Intelligent Platforms) wrote: > Add a driver for the DA830 EMAC. > > This is very similar to the davinci_emac driver. It has been restructured > to make it as similar as possible. Potentially the two could be merged, > but I don't have access to other davinci type platforms to test for > breakage after the inevitable mangling required. > > There are enough similarities between this and the in-tree Davinci code that it makes no sense to have a different driver. It also appears like you used an older Davinci driver as your source.
Don't worry so much about not being able to test on other hardware, since other people can. Just try your best to not break anything, and post the patches. As a general comment, please take great care to ensure that no lines have more than 78 characters, and that indentation is consistently by TAB, with tab width of 8 characters. Your patch has inconsistent indentation and long lines. regards, Ben _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
