Hi Jaehoon, On 18 January 2017 at 23:13, Jaehoon Chung <jh80.ch...@samsung.com> wrote: > Add the max8997 controller for Driver model. > Exynos4210 is using max8997 pmic controller. > (pmic_max8997.c should be deprecated.) > > Signed-off-by: Jaehoon Chung <jh80.ch...@samsung.com> > --- > drivers/power/pmic/Kconfig | 7 +++++ > drivers/power/pmic/Makefile | 1 + > drivers/power/pmic/max8997.c | 61 > ++++++++++++++++++++++++++++++++++++++++++++ > 3 files changed, 69 insertions(+) > create mode 100644 drivers/power/pmic/max8997.c
Reviewed-by: Simon Glass <s...@chromium.org> But please see comments below. > > diff --git a/drivers/power/pmic/Kconfig b/drivers/power/pmic/Kconfig > index 5e244c8..19494fa 100644 > --- a/drivers/power/pmic/Kconfig > +++ b/drivers/power/pmic/Kconfig > @@ -54,6 +54,13 @@ config DM_PMIC_MAX77686 > This config enables implementation of driver-model pmic uclass > features > for PMIC MAX77686. The driver implements read/write operations. > > +config DM_PMIC_MAX8997 config PMIC_MAX8997 Since I don't think you have a non-DM option here. > + bool "Enable Driver Model for PMIC MAX8997" > + depends on DM_PMIC > + ---help--- > + This config enables implementation of driver-model pmic uclass > features > + for PMIC MAX8997. The driver implements read/write operations. Can you mention a few details about the device? Number of LDOs, etc.? > + > config DM_PMIC_MAX8998 > bool "Enable Driver Model for PMIC MAX8998" > depends on DM_PMIC > diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile > index b4ac7d2..43f5557 100644 > --- a/drivers/power/pmic/Makefile > +++ b/drivers/power/pmic/Makefile > @@ -7,6 +7,7 @@ > > obj-$(CONFIG_DM_PMIC) += pmic-uclass.o > obj-$(CONFIG_DM_PMIC_MAX77686) += max77686.o > +obj-$(CONFIG_DM_PMIC_MAX8997) += max8997.o > obj-$(CONFIG_DM_PMIC_MAX8998) += max8998.o > obj-$(CONFIG_DM_PMIC_PFUZE100) += pfuze100.o > obj-$(CONFIG_PMIC_S2MPS11) += s2mps11.o > diff --git a/drivers/power/pmic/max8997.c b/drivers/power/pmic/max8997.c > new file mode 100644 > index 0000000..f749d7d > --- /dev/null > +++ b/drivers/power/pmic/max8997.c > @@ -0,0 +1,61 @@ > +/* > + * Copyright (C) 2016 Samsung Electronics > + * Jaehoon Chung <jh80.ch...@samsung.com> > + * > + * SPDX-License-Identifier: GPL-2.0+ > + */ > + > +#include <common.h> > +#include <dm.h> > +#include <i2c.h> > +#include <power/pmic.h> > +#include <power/max8997_pmic.h> > +#include <errno.h> nit: Should go above i2.h [...] Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
