Hi Maxime,
2017-01-12 6:48 GMT+09:00 Maxime Ripard <maxime.rip...@free-electrons.com>: > On Tue, Jan 10, 2017 at 07:57:22PM +0900, Masahiro Yamada wrote: >> 2017-01-10 17:04 GMT+09:00 Maxime Ripard <maxime.rip...@free-electrons.com>: >> > Hi, >> > >> > On Tue, Jan 10, 2017 at 01:32:08PM +0900, Masahiro Yamada wrote: >> >> The bare default entry is wrong. Just remove it since the (real) >> >> entry in drivers/mmc/Kconfig has "default ARM || PPC || SANDBOX". >> >> >> >> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> >> >> Reviewed-by: Marek Vasut <ma...@denx.de> >> >> --- >> >> >> >> Changes in v2: None >> >> >> >> board/sunxi/Kconfig | 4 ---- >> >> 1 file changed, 4 deletions(-) >> >> >> >> diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig >> >> index e1d4ab1..11eb82a 100644 >> >> --- a/board/sunxi/Kconfig >> >> +++ b/board/sunxi/Kconfig >> >> @@ -291,10 +291,6 @@ config OLD_SUNXI_KERNEL_COMPAT >> >> Set this to enable various workarounds for old kernels, this >> >> results in >> >> sub-optimal settings for newer kernels, only enable if needed. >> >> >> >> -config MMC >> >> - depends on !UART0_PORT_F >> >> - default y if ARCH_SUNXI >> >> - >> > >> > The default might be useless, but the additional depends on is really >> > not. >> >> This is wrong anyway. > > The original code might have been wrong, but you just introduced a > regression. > >> If you want to disable MMC, the following seems better. >> >> config MMC_SUNXI >> depends on ARCH_SUNXI && !UART0_PORT_F > > That looks great. Can you send a patch for it or add it to that serie? OK. Please check this: http://patchwork.ozlabs.org/patch/714139/ -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
