Hi, separation of rk3399 SPL from ATF SPL would be worth.
Thanks, Michal On 29.12.2016 11:25, Kever Yang wrote: > > RK3399 SPL is not enable bacause of the lack of ATF support in SPL, > after port some source code from ATF, I manage to enable the support for > ATF in SPL. This patch set depends on some patch for SPL support multi > binary in FIT which is from Andre. > > The patch of sdram controller is still not clean, because I want to get > comments from upstream.I port this driver from coreboot, and I don't > want to make much change on it. The rk3399 dram controller has many registers > to config, I want to make them directly used by driver instead of parse > and copy them one by one from dts. > > Another part of comment is welcome for the implementation of spl_atf.c > and the entry in spl.c > > > > Kever Yang (3): > arm64: rk3399: add SPL support > arm64: rk3399: add ddr controller driver > spl: add support to booting with ATF > > arch/arm/Kconfig | 1 + > arch/arm/dts/rk3399.dtsi | 24 + > arch/arm/include/asm/arch-rockchip/grf_rk3399.h | 118 ++ > arch/arm/include/asm/arch-rockchip/sdram_rk3399.h | 188 +++ > arch/arm/mach-rockchip/Kconfig | 2 + > arch/arm/mach-rockchip/Makefile | 1 + > arch/arm/mach-rockchip/rk3399-board-spl.c | 157 ++ > arch/arm/mach-rockchip/rk3399/Makefile | 1 + > arch/arm/mach-rockchip/rk3399/sdram-lpddr3-4GB.inc | 1565 > ++++++++++++++++++++ > arch/arm/mach-rockchip/rk3399/sdram_rk3399.c | 1121 ++++++++++++++ > common/spl/Kconfig | 14 + > common/spl/Makefile | 1 + > common/spl/spl.c | 4 + > common/spl/spl_atf.c | 91 ++ > configs/evb-rk3399_defconfig | 17 + > drivers/clk/rockchip/clk_rk3399.c | 42 +- > drivers/pinctrl/rockchip/pinctrl_rk3399.c | 106 -- > include/atf_common.h | 295 ++++ > include/configs/rk3399_common.h | 11 + > include/dt-bindings/clock/rk3399-cru.h | 16 +- > include/spl.h | 1 + > 21 files changed, 3663 insertions(+), 113 deletions(-) > create mode 100644 arch/arm/include/asm/arch-rockchip/sdram_rk3399.h > create mode 100644 arch/arm/mach-rockchip/rk3399-board-spl.c > create mode 100644 arch/arm/mach-rockchip/rk3399/sdram-lpddr3-4GB.inc > create mode 100644 arch/arm/mach-rockchip/rk3399/sdram_rk3399.c > create mode 100644 common/spl/spl_atf.c > create mode 100644 include/atf_common.h > _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot