Hi Tom,
2016-12-06 1:02 GMT+09:00 Tom Rini <tr...@konsulko.com>:
> On Sun, Dec 04, 2016 at 10:23:10PM +0900, Masahiro Yamada wrote:
>
>> Commit 7a777f6d6f35 ("mmc: Add generic Kconfig option") created
>> a Kconfig entry for this option without any actual moves, then
>> commit 44c798799f66 ("sunxi: Use Kconfig CONFIG_MMC") moved the
>> instances only for SUNXI.
>>
>> We generally do not like such partial moves. This kind of work
>> is automated by tools/moveconfig.py, so it is pretty easy to
>> complete this move.
>>
>> This commit was created as follows:
>>
>> [1] remove "depends on ARCH_SUNXI || SANDBOX" and
>> reword the prompt and help message (copied from Linux)
>> [2] run 'tools/moveconfig MMC'
>>
>> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
> [snip]
>> 801 files changed, 630 insertions(+), 197 deletions(-)
>
> OK. I think this means that we want MMC to be either default y or
> default y if ARM || POWERPC || SANDBOX, to cut down on the size here.
Nit. s/POWERPC/PPC/
(Unfortunately, U-Boot historically uses a different
config for PowerPC.)
I tried your suggestion.
It is true that 625 touched defconfigs were decreased to 389,
but do you think this is a really good idea?
Theoretically, nothing of MMC
is related to ARM, PowerPC, Sandbox.
I think this is shortening defconfigs
for the purpose of shortening.
BTW, do you know that
Kbuild subsystem is discussing a new keyword "imply" ?
https://patchwork.kernel.org/patch/9422463/
I am thinking it, if accepted, will be a better solution than
such unrelated "depends on <ARCH>" or "depends on <SOC>".
--
Best Regards
Masahiro Yamada
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
