On Mon, Nov 28, 2016 at 6:20 PM, Marek Vasut <ma...@denx.de> wrote: > On 11/28/2016 09:07 AM, Jagan Teki wrote: >> On Fri, Nov 25, 2016 at 8:08 PM, Phil Edworthy >> <phil.edwor...@renesas.com> wrote: >>> This series has fixes, patches to clean the code up, and add support for >>> specifying the sampling edge. >>> >>> Changed in v2: >>> spi: cadence_qspi: Fix baud rate calculation >>> spi: cadence_qspi: Fix CS timings (was "Fix CQSPI_CAL_DELAY calculation") >>> spi: cadence_qspi: Support specifying the sample edge used >>> >>> Added in v2: >>> spi: cadence_qspi: Better debug information on the SPI clock rate >>> >>> Phil Edworthy (8): >>> spi: cadence_qspi: Fix clearing of pol/pha bits >>> spi: cadence_qspi: Fix baud rate calculation >> >> Please fix the comment for this patch. > > Fix how ? It seems perfectly fine to me, so explain. > >>> spi: cadence_qspi: Better debug information on the SPI clock rate >>> spi: cadence_qspi: Use #define for bits instead of bit shifts >> >> And this one, > > DTTO, seems perfectly fine.
See my comments on these patch threads. thanks! -- Jagan Teki Free Software Engineer | www.openedev.com U-Boot, Linux | Upstream Maintainer Hyderabad, India. _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
