Hi Hans, On Fri, Nov 25, 2016 at 09:12:30AM +0100, Hans de Goede wrote: > Hi, > > On 24-11-16 22:22, Maxime Ripard wrote: > > On Wed, Nov 23, 2016 at 07:28:16PM +0100, Jelle van der Waa wrote: > > > Introduce a new CONFIG_SATAPWR Kconfig option to replace the > > > option in CONFIG_SYS_EXTRA_OPTIONS. > > > > > > Signed-off-by: Jelle van der Waa <je...@vdwaa.nl> > > > --- > > > board/sunxi/Kconfig | 7 +++++++ > > > board/sunxi/board.c | 11 ++++++----- > > > configs/A10-OLinuXino-Lime_defconfig | 3 ++- > > > configs/A20-OLinuXino-Lime2_defconfig | 3 ++- > > > configs/A20-OLinuXino-Lime_defconfig | 3 ++- > > > configs/A20-OLinuXino_MICRO_defconfig | 3 ++- > > > configs/A20-Olimex-SOM-EVB_defconfig | 3 ++- > > > configs/Cubieboard2_defconfig | 3 ++- > > > configs/Cubieboard_defconfig | 3 ++- > > > configs/Cubietruck_defconfig | 3 ++- > > > configs/Itead_Ibox_A20_defconfig | 3 ++- > > > configs/Lamobo_R1_defconfig | 3 ++- > > > configs/Linksprite_pcDuino3_Nano_defconfig | 3 ++- > > > configs/Linksprite_pcDuino3_defconfig | 3 ++- > > > configs/Sinovoip_BPI_M3_defconfig | 2 +- > > > configs/orangepi_plus_defconfig | 3 ++- > > > 16 files changed, 40 insertions(+), 19 deletions(-) > > > > > > diff --git a/board/sunxi/Kconfig b/board/sunxi/Kconfig > > > index ae2fba1..fe2f7b4 100644 > > > --- a/board/sunxi/Kconfig > > > +++ b/board/sunxi/Kconfig > > > @@ -667,6 +667,13 @@ config GMAC_TX_DELAY > > > ---help--- > > > Set the GMAC Transmit Clock Delay Chain value. > > > > > > +config SATAPWR > > > + string "power pin for SATA" > > > + default "" > > > + ---help--- > > > + Set the power pin for SATA. This takes a string in the format > > > + understood by sunxi_name_to_gpio, e.g. PH1 for pin 1 of port H. > > > + > > > > This looks like a rather generic option. Can't this be in > > drivers/block instead? > > The proper solution would be to get the info from devicetree, > which requires regulator support, which we don't have yet > for sunxi. In the mean time getting rid of the need for > CONFIG_SYS_EXTRA_OPTIONS is a worthwhile goal in itself > IMHO.
Yes, but a GPIO to enable the SATA 5V rail seems like a rather common thing, and definitely not Allwinner specific. Moving that option to drivers/block would make more sense I guess. Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
signature.asc
Description: PGP signature
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
