Hi,
> -----Original Message-----
> From: Jagan Teki [mailto:ja...@openedev.com]
> Sent: Wednesday, November 16, 2016 9:33 AM
> To: u-boot@lists.denx.de
> Cc: Jagan Teki <ja...@openedev.com>; Simon Glass <s...@chromium.org>;
> Bin Meng <bmeng...@gmail.com>; York Sun <york....@nxp.com>; Vignesh
> R <vigne...@ti.com>; Mugunthan V N <mugunthan...@ti.com>; Michal
> Simek <michal.si...@xilinx.com>; Siva Durga Prasad Paladugu
> <siva...@xilinx.com>
> Subject: [PATCH v6 04/21] sf: Cleanup spi_flash_info{}
>
> - Proper tabs spaces
> - Removed unnecessary
> - Added meaningful comments
>
> Cc: Simon Glass <s...@chromium.org>
> Cc: Bin Meng <bmeng...@gmail.com>
> Cc: York Sun <york....@nxp.com>
> Cc: Vignesh R <vigne...@ti.com>
> Cc: Mugunthan V N <mugunthan...@ti.com>
> Cc: Michal Simek <michal.si...@xilinx.com>
> Cc: Siva Durga Prasad Paladugu <siva...@xilinx.com>
> Signed-off-by: Jagan Teki <ja...@openedev.com>
Reviewed-by: Siva Durga Prasad Paladugu <siva...@xilinx.com>
Thanks,
Siva
> ---
> drivers/mtd/spi/sf_internal.h | 24 ++++++++++--------------
> 1 file changed, 10 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/mtd/spi/sf_internal.h b/drivers/mtd/spi/sf_internal.h
> index a9455ac..d7ac6b3 100644
> --- a/drivers/mtd/spi/sf_internal.h
> +++ b/drivers/mtd/spi/sf_internal.h
> @@ -108,17 +108,9 @@ int sst_write_bp(struct spi_flash *flash, u32 offset,
> size_t len,
> #define JEDEC_ID(info) (((info)->id[1]) << 8 | ((info)->id[2]))
> #define JEDEC_EXT(info) (((info)->id[3]) << 8 | ((info)->id[4]))
>
> -/**
> - * struct spi_flash_info - SPI/QSPI flash device params structure
> - *
> - * @name: Device name
> ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO])
> - * @sector_size: Isn't necessarily a sector size from vendor,
> - * the size listed here is what works with
> CMD_ERASE_64K
> - * @nr_sectors: No.of sectors on this device
> - * @flags: Important param, for flash specific behaviour
> - */
> struct spi_flash_info {
> - const char *name;
> + /* Device name ([MANUFLETTER][DEVTYPE][DENSITY][EXTRAINFO]) */
> + const char *name;
>
> /*
> * This array stores the ID bytes.
> @@ -128,12 +120,16 @@ struct spi_flash_info {
> u8 id[5];
> u8 id_len;
>
> - u32 sector_size;
> - u32 nr_sectors;
> + /*
> + * The size listed here is what works with SPINOR_OP_SE, which isn't
> + * necessarily called a "sector" by the vendor.
> + */
> + u32 sector_size;
> + u32 nr_sectors;
>
> - u16 page_size;
> + u16 page_size;
>
> - u16 flags;
> + u16 flags;
> #define SECT_4K BIT(0)
> #define E_FSR BIT(1)
> #define SST_WR BIT(2)
> --
> 1.9.1
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
