On 2016-11-15 00:52, B, Ravi wrote:
> Stefan
>
>> From: Stefan Agner <stefan.ag...@toradex.com>
>
>>This patchset cleans up the SPL USB Gadget Kconfig and Makfile.
>>The first two patches are actual fixes and we might consider to add these two
>>for the v2016.11 release. The third one adds a new config option for cleaner
>>structure. I plan to add another USB function with SPL support which is the
>>reason I looked into this...
>
>>Build tested using buildman for all boards on powerpc mips and arm. No new
>>errors or warnings:
>>Building 4 commits for 1072 boards (8 threads, 1 job per thread)
> >4044 0 244 /4288 P1022DS_NAND
>
>>This patchset is probably most interesting for am335x_evm_usbspl_defconfig
>>(CONFIG_SPL_USBETH_SUPPORT) And the board with which SPL DFU support has been
>>introduced dra7xx_evm_defconfig (CONFIG_SPL_DFU_SUPPORT, not set by default)
>
>>Due to lack of any of this hardware I did not run the binaries!
>>Since it is mostly Makefile shuffling I don't expect any runtime behavior
>>changes... If anyone (maybe Ravi or Lukasz, afaik you worked on the SPL DFU
>>support for dra7xx_evm) could test the patchset on actual hardware I would be
>>glad!
>
> Sure, I will test SPL-DFU with this patches on dra7xx platform.
>
> But I see SPL-DFU does not compile (dra7xx_evm_defconfig) in current
> mainline. Due to other patches came in, and also SPL-DFU disabled, I
> agree reason to reduce spl image size limit ("usb:gadget: Disallow DFU
> in SPL for now" commit:6ad6a10), need to compile out dfu gadget when
> SPL-DFU not selected.
> First I will fix the spl-dfu compile issue and then will test this patch
> series.
This patchset fixes exactly that issue! No need to fix it twice :-)
I just tested it again, and actually realized that I made an error in
the third patch which does not allow to select SPL_DFU_SUPPORT.
Adding this:
config SPL_DFU_SUPPORT
bool "Support DFU (Device Firmware Upgarde)"
- depends on SPL_GADGET_SUPPORT
+ depends on SPL_USB_GADGET_SUPPORT
select SPL_HASH_SUPPORT
help
This feature enables the DFU (Device Firmware Upgarde) in SPL
with
Allows to select SPL / TPL ---> Suppport USB Gadget drivers, and
Support DFU (Device Firmware Upgarde). This compiles fine now.
Will send a v3 which integrates that fix.
--
Stefan
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
