On Sat, 12 Nov 2016 10:36:42 +0100 Marek Vasut ma...@denx.de wrote: ... > > udev = dev_get_parent_priv(child); > > + if (!udev) > > + continue; > > I don't quite understand the problem from the patch description, but > shouldn't all the return values from dev_get_parent_priv() be checked > this way , not just these two ?
The problem is that when dereferencing NULL udev we later access some random address (e.g. when accessing dev->dev->parent in usb_show_tree_graph()). dev->dev pointer is random DRAM data there, when dereferencing it, data abort happens when random address is outside of valid address range. Probably we should check elsewhere, at least where it might return NULL. > > Why does dev_get_parent_priv() return NULL here ? it returns NULL because the dev->parent_priv is not allocated for usb_mass_storage.lun0 device. I do not know the reason why. -- Anatolij _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
