Hi, On 10 November 2016 at 03:58, Zhiqiang Hou <zhiqiang....@nxp.com> wrote: > From: Minghuan Lian <minghuan.l...@nxp.com> > > There may be multiple PCIe controllers in a SoC. > It is not correct that always calling pci_bus_to_hose(0) to get > the first PCIe controller for the PCIe device connected other > controllers. We just remove this calling because hose always point > the correct PCIe controller. > > Signed-off-by: Minghuan Lian <minghuan.l...@nxp.com> > Signed-off-by: Hou Zhiqiang <zhiqiang....@nxp.com> > --- > V2: > - No change > > drivers/pci/pci_common.c | 10 ---------- > 1 file changed, 10 deletions(-)
So is 'hose' always a root PCI controller now? If so, can you comment these in the header? I'm a bit confused by this We should perhaps move the regions[] array into its own struct separate from pci_controller. > > diff --git a/drivers/pci/pci_common.c b/drivers/pci/pci_common.c > index 1755914..448e814 100644 > --- a/drivers/pci/pci_common.c > +++ b/drivers/pci/pci_common.c > @@ -181,11 +181,6 @@ phys_addr_t pci_hose_bus_to_phys(struct pci_controller > *hose, > return phys_addr; > } > > -#ifdef CONFIG_DM_PCI > - /* The root controller has the region information */ > - hose = pci_bus_to_hose(0); > -#endif > - > /* > * if PCI_REGION_MEM is set we do a two pass search with preference > * on matches that don't have PCI_REGION_SYS_MEMORY set > @@ -248,11 +243,6 @@ pci_addr_t pci_hose_phys_to_bus(struct pci_controller > *hose, > return bus_addr; > } > > -#ifdef CONFIG_DM_PCI > - /* The root controller has the region information */ > - hose = pci_bus_to_hose(0); > -#endif > - > /* > * if PCI_REGION_MEM is set we do a two pass search with preference > * on matches that don't have PCI_REGION_SYS_MEMORY set > -- > 2.1.0.27.g96db324 > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
