Hi Cédric, On 6 November 2016 at 21:06, Cédric Schieli <cschi...@gmail.com> wrote: > > 2016-11-06 1:36 GMT+01:00 Jonathan Liu <net...@gmail.com>: >> >> I did a similar patch without noticing you already submitted this series. >> The save_boot_params function can be written in C instead of assembly >> and placed in rpi.c. >> See >> https://lists.yoctoproject.org/pipermail/yocto/2016-November/032934.html >> for how to write save_boot_params in C as this can simplify your >> patch. It also has a U-Boot script for using the FDT provided by the >> firmware, though you would need to change ${fdt_addr_r} to >> ${fw_fdt_addr} for it to work with your patch series. > > > I do not have a strong opinion on wether save_boot_params should be C or > assembly code. I'll opt for what the maintainers prefer here. > > Regarding the script, I'll include a example in my next version. I don't > like the idea to hijack ${fdt_addr_r} as it is documented as a pointer to > where one can manually load a custom FDT blob. If we make it points to the > firmware provided one and the user manually loads a bigger blob, unexpected > results may happen.
Yes, I prefer your method of storing it in a separate environment variable. Regards, Jonathan _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
