Hi Otavio, On 11/10/2016 20:16, Otavio Salvador wrote: > On Tue, Oct 11, 2016 at 11:09 AM, Diego Dorta <diego.do...@nxp.com> wrote: >> Allow i.MX6Q Sabre SD to load the kernel and dtb via SPL in Falcon mode. >> >> Based on the Falcon mode code for MX6 Gateworks Ventana board. >> >> Signed-off-by: Diego Dorta <diego.do...@nxp.com> >> --- >> board/freescale/mx6sabresd/mx6sabresd.c | 12 ++++++++++++ >> include/configs/mx6sabresd.h | 12 ++++++++++++ >> 2 files changed, 24 insertions(+) >> >> diff --git a/board/freescale/mx6sabresd/mx6sabresd.c >> b/board/freescale/mx6sabresd/mx6sabresd.c >> index e58c03c..2b6d7be 100644 >> --- a/board/freescale/mx6sabresd/mx6sabresd.c >> +++ b/board/freescale/mx6sabresd/mx6sabresd.c >> @@ -57,6 +57,8 @@ DECLARE_GLOBAL_DATA_PTR; >> >> #define DISP0_PWR_EN IMX_GPIO_NR(1, 21) >> >> +#define KEY_VOL_UP IMX_GPIO_NR(1, 4) >> + >> int dram_init(void) >> { >> gd->ram_size = imx_ddr_size(); >> @@ -682,6 +684,16 @@ int checkboard(void) >> #include <spl.h> >> #include <libfdt.h> >> >> +#ifdef CONFIG_SPL_OS_BOOT >> +int spl_start_uboot(void) >> +{ >> + gpio_direction_input(KEY_VOL_UP); >> + >> + /* Only enter in Falcon mode if KEY_VOL_UP is pressed */ >> + return gpio_get_value(KEY_VOL_UP); > > I would prefer if it booted on falcon by default and vol-up could make > it load the U-Boot.img as a recovery option. >
For customer boards or final products, I absolutely agree with you. In case of an evaluation board as this one, I tend to support Fabio's concerns, and let the board to start as default U-Boot. Newbie can start to check the board and when they become confident they have still the possibility to switch to optimization like Falcon mode. Best regards, Stefano -- ===================================================================== DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sba...@denx.de ===================================================================== _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot