Dear Martha M Stan,
In message <12535564802137-git-send-email-mm...@silicontkx.com> you wrote:
> Signed-off-by: Martha M Stan <mm...@silicontkx.com>
> ---
> board/freescale/mpc5121ads/mpc5121ads.c | 98
> ++++++++++++++++++++++++++++++-
> include/configs/mpc5121ads.h | 35 ++++++++++-
> 2 files changed, 129 insertions(+), 4 deletions(-)
>
> diff --git a/board/freescale/mpc5121ads/mpc5121ads.c
> b/board/freescale/mpc5121ads/mpc5121ads.c
> index 8defb00..4315734 100644
> --- a/board/freescale/mpc5121ads/mpc5121ads.c
> +++ b/board/freescale/mpc5121ads/mpc5121ads.c
...
> phys_size_t initdram(int board_type)
> {
> - u32 msize = 0;
> + /* Elpida MDDRC and initialization settings are an alternative
> + * to the Default Micron ones for all but the earliest Rev 4 boards
> + */
Incorrect multiline comment style. Fixed.
> + u32 elpida_mddrc_config[4] = {
> + CONFIG_SYS_MDDRC_SYS_CFG_ELPIDA,
> + CONFIG_SYS_MDDRC_TIME_CFG0,
> + CONFIG_SYS_MDDRC_TIME_CFG1_ELPIDA,
> + CONFIG_SYS_MDDRC_TIME_CFG2_ELPIDA
> + };
> +
> + u32 elpida_init_sequence[] = {
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_PCHG_ALL,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_RFSH,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_RFSH,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_EM2,
> + CONFIG_SYS_DDRCMD_EM3,
> + CONFIG_SYS_DDRCMD_EN_DLL,
> + CONFIG_SYS_ELPIDA_RES_DLL,
> + CONFIG_SYS_DDRCMD_PCHG_ALL,
> + CONFIG_SYS_DDRCMD_RFSH,
> + CONFIG_SYS_DDRCMD_RFSH,
> + CONFIG_SYS_DDRCMD_RFSH,
> + CONFIG_SYS_ELPIDA_INIT_DEV_OP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_OCD_DEFAULT,
> + CONFIG_SYS_ELPIDA_OCD_EXIT,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP,
> + CONFIG_SYS_DDRCMD_NOP
> + };
>
> - msize = fixed_sdram(NULL, NULL, 0);
> + u32 msize = 0;
> + if (is_micron()) {
Please empty line after variable declarations.
Applied & fixed.
Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: w...@denx.de
"No proper program contains an indication which as an operator-
applied occurrence identifies an operator-defining occurrence which
as an indication-applied occurrence identifies an indication-defining
occurrence different from the one identified by the given indication
as an indication-applied occurrence." - ALGOL 68 Report
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
