Hi Simon,
2016-09-27 9:34 GMT+09:00 Simon Glass <s...@chromium.org>: > Hi Masahiro, > > On 25 September 2016 at 22:05, Masahiro Yamada > <yamada.masah...@socionext.com> wrote: >> Currently, the check-config.sh terminates the build when unknown >> ad-hoc options are detected. I think it is too much because we may >> want to patch config headers locally in a build/deployment project. >> >> So, let's relax check-config.sh to just warn even if it detects >> options that are not in the whitelist. Instead, this check can be >> done at the end of build, along with other checks. It will catch >> more attention. >> >> Even with this change, the Buildman tool catches new warnings, >> so Tom can give NACK to new ad-hoc options. >> >> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> >> --- >> >> scripts/check-config.sh | 3 +-- >> 1 file changed, 1 insertion(+), 2 deletions(-) > > I am not sure this is a good idea. We need buildman to fail the build; > otherwise patches will make it to mainline with new CONFIGs. Perhaps > we should have an ENV variable to skip the check? It is OK for me as long as there is a way to work-around this check, ENV or whatever. -- Best Regards Masahiro Yamada _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
