Hi Steve, On 27 August 2016 at 16:15, Steve Rae <steve....@raedomain.com> wrote: > handle FASTBOOT_FLASH_MMC_DEV default properly > > Signed-off-by: Steve Rae <steve....@raedomain.com> > --- > I was hoping that the FASTBOOT_FLASH_MMC_DEV Kconfig option could be > an integer (eg. 0, 1, or 2 etc.) or undefined (to signify that it > is not being used). However, it seems that (Kconfig experts please!) > this is not correct within Kconfig. > Therefore, I have implemented "-1" to signify that it is not used. > Is this the "best practice" for handling this scenario?
I think it might be better to have a bool option which enables/disables the feature, as well as what you have here. Then you don't need the -1 value. > > cmd/fastboot/Kconfig | 4 +++- > common/Makefile | 4 +++- > drivers/usb/gadget/f_fastboot.c | 12 ++++++++---- > 3 files changed, 14 insertions(+), 6 deletions(-) > > diff --git a/cmd/fastboot/Kconfig b/cmd/fastboot/Kconfig > index a93d1c0..fdd5475 100644 > --- a/cmd/fastboot/Kconfig > +++ b/cmd/fastboot/Kconfig > @@ -50,10 +50,12 @@ config FASTBOOT_FLASH > Regards, Simon _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
