On Tuesday 22 September 2009 16:41:45 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > ... > > > > > > > $(obj)u-boot.ldr: $(obj)u-boot > > > > - $(obj)tools/envcrc --binary > $(obj)env-ldr.o > > > > + $(CREATE_LDR_ENV) > > > > $(LDR) -T $(CONFIG_BFIN_CPU) -c $@ $< $(LDR_FLAGS) > > > > > > This is all BF specific stuff, right? Maybe we should move this into > > > some BF Makefile, then, instead of adding more and more references to > > > magic variables that have no meaning anywhere except for BF. > > > > if you're talking about the %.ldr target, then yes, it is only for > > Blackfin systems. it isnt the only target-specific top level which is > > why it's there now, but that doesnt mean it has to stay there (as well as > > the other cruft). ive already looked at moving this to the Blackfin > > specific config.mk, but it would require adding dummy "all" targets early > > on in the top level Makefile and one or two subdir Makefiles. i didnt > > feel like dealing with people complaining about this. although if we > > created a new lib_$(ARCH)/targets.mk, we could push all arch-specific > > crap there (like all the boards config targets), and only the top level > > Makefile would include it. > > I'm not asking for a general Makefile rework. But maybe we can move > this code to some BF Makefile?
well if i'm going to do it for the Blackfin arch, i might as well generalize it and do it the right way the first time ... -mike
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot