Minkyu Kang wrote: > Dear Tom > > 2009/9/22 Tom <[email protected]>: >> Minkyu Kang wrote: >>> This patch includes the serial driver for s5pc1xx >>> >>> Signed-off-by: Minkyu Kang <[email protected]> >> Nak. >> >> This looks like the zoom2 serial driver. >> In the case of zoom2, special handling is needed because the >> serial is supplied by a detachable debug board and a >> runtime check was needed. >> >> You are not doing a runtime check so why can you not just use >> one of the generic interfaces ? >> >> Tom > > Sorry, I don't understand your pointing. > I referenced s3c24x0 serial driver, > > please explain more detail.
It is unclear from your commit log why you can not just use the generic drivers/serial/ns16550.c. Looking closer at the patch I see that you return from getc if a modem is being used. Assuming that the commit log will be fixed, I will review the patch again. Tom _______________________________________________ U-Boot mailing list [email protected] http://lists.denx.de/mailman/listinfo/u-boot
