Minkyu Kang wrote: > Dear Tom > > 2009/9/22 Tom <tom....@windriver.com>: >> Minkyu Kang wrote: >>> This patch adds support for the Samsung s5pc100 and s5pc110 >>> SoCs. The s5pc1xx SoC is an ARM Cortex A8 processor. >>> >>> Signed-off-by: Minkyu Kang <mk7.k...@samsung.com> >>> Signed-off-by: HeungJun, Kim <riverful....@samsung.com> >> Ack-ed >> Tom >> _______________________________________________ >> U-Boot mailing list >> U-Boot@lists.denx.de >> http://lists.denx.de/mailman/listinfo/u-boot >> > > Thanks for review > > and I have one question > when I send next patch or commit this patch, should I add Acked-by?
Good question! From the way you submitted the patch, you added yourself as the sign off line. When you push the patch, you may add me to the sign off. As long as the original author gets the credit. This is also useful so multiple re-reviews of an ack-ed patch do not stall submission. Tom > > Thanks again > Minkyu Kang _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
