On 09/16/2016 11:35 AM, Sriram Dash wrote: [...]
>>> I agree to your point. We can set the bit from fsl specific file with >>> the function setbits_le32(fsl_xhci->dwc3_reg->g_usb3pipectl[0], >>> DWC3_GUSB3PIPECTL_DISRXDETP3); >>> If any other Soc, other than fsl/nxp wants the functionality, they >>> will be using the same in their respective code. What do you say? >> >> Why do you use setbits_le32() instead of writel() ? >> > > We will be modifying a single bit. So, better to use setbit_le32 and > leave other bits unchanged. In that case, you should use clrsetbits_le32() to clear the bit first in case someone decided to clear it instead. [...] -- Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
