hi Vagrant,
On 2016年09月09日 03:28, Vagrant Cascadian wrote:
On 2016-09-08, Kever Yang wrote:
The rk3288 spl size is very close to 32KB while the rk3288 bootrom
has the limitation of maximum size of SPL is 32KB. After apply this
patch, the SPL size will exceed 32KB if we do not enable macro
CONFIG_ROCKCHIP_SPL_BACK_TO_BROM.
I think this patch is usful and should be go upstream other than the
size issue.
This patch has test with 2GB DDR3 and 2GB/4GB LPDDR3.
Thanks for the patch!
Unfortunately, fails to build the firefly-rk3288 target, using
arm-linux-gnueabihf-gcc (Debian 6.1.1-9) 6.1.1 20160705, applied to
u-boot master 01c5075506afcb7a74e0db8600af8979f45881b5:
CC spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
'conv_of_platdata':
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1042:30: error: 'struct
dtd_rockchip_rk3288_dmc' has no member named 'rockchip_num_channels';
did you mean 'rockchip_noc'?
plat->num_channels = of_plat->rockchip_num_channels;
- plat->num_channels = of_plat->rockchip_num_channels;
+ plat->num_channels = 2;
firefly-rk3288 deploy CONFIG_OF_PLATDATA, driver read platform data
from include/generated/dt-structs.h which is generated according to dts
file.
Please try above change.
@Kever,
Please fix below.
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c: In function
‘conv_of_platdata’:
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1035:6: warning: unused
variable ‘i’ [-Wunused-variable]
^~
arch/arm/mach-rockchip/rk3288/sdram_rk3288.c:1035:6: warning: unused
variable 'i' [-Wunused-variable]
int i, ret;
^
scripts/Makefile.build:280: recipe for target
'spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o' failed
make[3]: *** [spl/arch/arm/mach-rockchip/rk3288/sdram_rk3288.o] Error 1
scripts/Makefile.build:425: recipe for target
'spl/arch/arm/mach-rockchip/rk3288' failed
make[2]: *** [spl/arch/arm/mach-rockchip/rk3288] Error 2
scripts/Makefile.spl:292: recipe for target 'spl/arch/arm/mach-rockchip'
failed
make[1]: *** [spl/arch/arm/mach-rockchip] Error 2
Makefile:1334: recipe for target 'spl/u-boot-spl' failed
make: *** [spl/u-boot-spl] Error 2
live well,
vagrant
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot
