On 09/08/2016 11:47 AM, Masahiro Yamada wrote:
> Creating multiple entries of "config FOO" often gives us bad
> experiences.  In this case, we should specify "default X86"
> as platforms that want this keyboard by default.

Yep, I like this patch:

Acked-by: Marek Vasut <ma...@denx.de>

btw on some of my computers , the 8042 is physically removable ;-)

> Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com>
> ---
> 
>  arch/x86/Kconfig      | 3 ---
>  drivers/input/Kconfig | 1 +
>  2 files changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 9207549..ac2d598 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -546,9 +546,6 @@ config I8254_TIMER
>         Intel 8254 timer contains three counters which have fixed uses.
>         Include this to have U-Boot set up the timer correctly.
>  
> -config I8042_KEYB
> -     default y
> -
>  config SEABIOS
>       bool "Support booting SeaBIOS"
>       help
> diff --git a/drivers/input/Kconfig b/drivers/input/Kconfig
> index d560328..b3873c1 100644
> --- a/drivers/input/Kconfig
> +++ b/drivers/input/Kconfig
> @@ -17,6 +17,7 @@ config CROS_EC_KEYB
>  config I8042_KEYB
>       bool "Enable Intel i8042 keyboard support"
>       depends on DM_KEYBOARD
> +     default X86
>       help
>         This adds a driver for the i8042 keyboard controller, allowing the
>         keyboard to be used on devices which support this controller. The
> 


-- 
Best regards,
Marek Vasut
_______________________________________________
U-Boot mailing list
U-Boot@lists.denx.de
http://lists.denx.de/mailman/listinfo/u-boot

Reply via email to